What rock is yellow and has a foul odor and is used in the manufacture of gunpowder?

The rock you're referring to is likely sulfur. Sulfur is a yellow, brittle non-metal that is known for its distinct foul odor, especially when burned. It is commonly used in the manufacture of gunpowder, as well as in various industrial processes, fertilizers, and other chemical applications.