Who wrote the words to a famous World War I song?

Pack up your troubles.... It's a long way to Tipperary.... Goodbye Dolly Grey ( Though I think this pre dates WW1) Marching songs were very important. Soldiers singing, whichever army they were in, was a good way of uniting men & forming esperit de corps.