What is the hobby of collecting firearms?

You have defined it. It is a hobby (past time, recreation, if you like) that encompasses the acquisition of firearms for knowledge, use, and potential to make money.