Once all the state quarters have come out in 2008 how much will a full collection of all state quarters all in fairly good condition both D and P along with a few bicentenial quarters be worth?

I expect to be able to buy full sets for $12.50 or possibly even less when people consign them to absolute auctions. There will be so many sets around that they will not bring a significant premium for a century, unless one of series has a very small mintage for some reason. If your coins came out of circulation, they will not have any added value, and probably never will. This is because there are so many people making sets from coins in uncirculated condition -- nobody will want a circulated set when an uncirculated set is so easily available for so little of a price. There are hundreds of millions of each state / each mint produced. It's not likely any of them will ever be considered rare or valuable. If you're making a state quarter set, don't do it for any investment potential, do it for the enjoyment of getting all the coins together and having them all.