I am 5'8 140 pounds and 17 is that a good weight?

Then your weight is good for that height. The average weight for someone who is 5'8 is 125-155. Since you're only 17 you are most likely going to grow taller until you hit 24.