Which is correct a self-confessed perfectionist or a self-professed perfectionist?

Both are correct; it depends on how you wish to use them.

Self-confessed means that one is simply admitting, confessing.

Self-professed means that one is announcing, advertising.