Is it better to sell silver quarters for their weight or as a quarter?

It depends on the silver content and current silver price. Most silver quarters (pre-1965) are usually worth more for their silver weight than their face value of 25p (or collector value, unless it’s rare). If the quarter isn’t a key date or in exceptional condition, selling it by weight to a silver buyer typically gets you the best return.