Did the seventh earl of cardigan have any children?

Yes, the seventh Earl of Cardigan, James Thomas Brudenell, had children. He married Lady Mary Gordon-Lennox, and they had two daughters, Lady Elizabeth and Lady Mary. However, he did not have any sons.