Is making hay while the sun shines an idiom?

No, an idiom is a phrase that makes no sense unless you know the definition. This makes perfect sense, so it's not an idiom. It is a proverb teaching you to do things when the time is right and not wait.