Should people make more of an effort to keep some things private?

That's not a general question. Undoubtedly, some people should... but it depends on the person and the situation entirely. Revealing ourselves to others is an important part of learning to love, trust, and communicate. But we also need to be careful of other people's feelings, and some people are offended by self-disclosure.