Why didn't the confederates win the civil war?

Because of these overwhelming Union advantages:

Much bigger population from which to recruit armies.

Traditional advantage in artillery, including new rifled cannon

Industrial capability - access to all kinds of war-supplies

More railroad mileage - whole armies could move by train

Big enough navy to blockade Southern coast

Most talented President the Americans ever had