How are heat engines classified?

heat engines are classified on the location of the combustion chamber , if it is outside the whole set up then it is external heat engine and vice versa.