How tall should the a gun cabinet be?

No real way to answer that, except it will depend on the length of the guns you want to store in it. Some are quite short, some are very long. I would add 4 inches to the length of the longest gun to have room to move them.