A three year plan -should it be hyphenated?

Yes, "three-year plan" should be hyphenated. The hyphen connects the Words "three" and "year" to indicate that they collectively modify the noun "plan." This helps to clarify that the plan is specifically designed for a duration of three years.