Did Otis Campbell the town drunk on the Andy Griffith show have a job?

Yes. In one episode they mention he works as a gluer in a chair factory (not sure of specific). They mention that he is sober and hard working during the week, but gets inuberiated during the weekend.