Do goldsmith make weapons

Traditionally they did not. While some elements of metalworking translate easily across media and specialized training, the term "goldsmith" implies a high level of refined technique that would have been brought to bear on more decorative items such as jewelry or hollowware. The blacksmith's trade has been more closely associated with weapon-making.