Is an M4 22lr with 30 round clip legal in ny?

Magazine, not clip. If the rifle was manufactured after the passage of the 1994 Clinton ban, then it can only have one of the features listed in the BATFE's definition of a so-called "civilian assault rifle" (i.e., bayonet lug, flash suppressor, pistol grip, collapsible buttstock, etc.). One of these features is legal in NY state - two or more is not. New York also restricts the capacity of magazines manufactured after 1994 to ten rounds, so the magazine you mention would not be legal.