Why do people question themselves so much?

They're just curious. It is like an instinct.

People constantly wonder about everything - what would happen if you made a different choice, what could you have done better or differently? This is part of the consequences of having a big brain that can think of things like that.