Was William McKinley ever a US Senator?

No. McKinley was never a Senator. He did serve five terms in the low House and was governor of Ohio before he became US President.