Is punish have a short vowel?

Yes, the Word "punish" has a short vowel sound in the first syllable. The "u" in "pun" is pronounced with a short /ʌ/ sound.