Does weeping willow make good firewood?

No, it is not very good firewood. It's actually a softwood, like spruce, as opposed to a hardwood, like oak or maple - so it doesn't burn very cleanly. Not only will you probably see more smoke with willow (and more creosote build-up), but the amount of heat it produces is significantly low. Hope that helps!