Should year to date have hyphens?

Yes, "year to date" should be hyphenated when used as a compound adjective before a noun, as in "year-to-date performance." However, when it appears after the noun, such as "the performance year to date," no hyphens are needed. Always consider the context to determine the correct usage.