Who makes guns for the military?

Depends on which gun, and which military. In some countries, a factory operated by the government (known as an arsenal) makes them. In the US, private companies compete for a contract to make guns for the military.