Why was the girl scout uniform changed from metal zippers down the front to buttons?

It was probably done to save money at the time because World War 2 was going on at the time so they switched to buttons.

Another answer:

Zippers may have been switched to buttons so that the metal saved from not having zippers could be used in the war effort.