How long should you charge?

Depends on what you are charging and the output of the charger. That is why an automatic charger is always best. No chance of overcharging the battery.