Which is better a flash drive or a CD-r?

One cannot be said to really be "better" than the other. When a CD-R has been recorded to, it exhibits all the properties of a traditional CD-ROM. A pressed CD-ROM has a slightly higher theoretical lifespan, but real-world conditions place them at about equal rates of deterioration.