Is the weakness of a Pokemon based on attack or type?

Both. If your attack is good against another pokemons TYPE then it will be super effective. If your pokemons type resists their attack then it will be not very effective. Water attack is super effective against fire.