Should you give up on singing?

No of course not. Never give up on anything. If you would like to become better at controlling your voice in to a way that sounds great maybe you should take up voice lessons. Their fun and usually not terribly expensive.

Hope This Helps!:)