Are Salmon berries yellow or red?

Both. There are color variants of ripe berries ranging from a golden yellow, similar to yellow raspberries, to a dark red. The reference to "salmon" comes from the fact that the "druplets" making up each berry are similar in color and shape to salmon eggs.