Did they shoot the heron in the white heron or not?

No, Sylvia saw the heron and could have told the man where the bird was, but the beauty of the bird impressed her so, that she was willing to give up the money the man was going to give her in order to let the bird live.