Should attorney general be hyphenated

No, "attorney general" should not be hyphenated. It is a noun phrase where "attorney" serves as a modifier for "general," and in standard usage, it is written as two separate Words. Hyphenation is not necessary in this case, as the phrase is widely recognized and understood without it.