What is the best scuba diving place in Egypt?

Sharm EL Sheik.

There boats cover a large section of the Red Sea including the Wreck of the Thistelgorm and the Ras Mohammed Marine park.

Hurgada is another possibility.