Was American democracy under threat during the Great Depression?

No. Though machine politics played a role in elections involving Franklin Delano Roosevelt, there was no serious threat that a Dictatorship would form during the Depression. The US lacked the machinery to allow a dictatorship to form - secret police forces, massive standing military forces, or a slave-labor economy.