Does nonproductive cough get a hyphen?

Yes, "nonproductive cough" does not require a hyphen when used as a noun phrase. However, if used as a compound adjective before a noun, it can be hyphenated as "non-productive cough." Generally, the preferred form is without a hyphen in most medical contexts.