What is a princesses brother called?

It depends upon why she is a princess. If it is because they are both the children of the king or queen, he would be a Prince. If it is because she is the wife of a Prince, (as with Princess Diana) her brother would have what ever title he got from his father.