Why was aleister crowley evil?

That depends on your concept of of "Good" and "Evil". He taught the importance of attaining Knowledge and Conversation with your Holy Guardian Angel and finding ones True Will. Besides that he was known for shocking the public, for instance, with stories of his sex and drug orgies in Sicily.