How long will felonies come up on a job background check?

They will come up for the rest of your life. It is part of the disincentive to prevent people from being criminals.