Should Bluestar from Warriors have given her kits up to become deputy of Thunderclan?

This would be a complete matter of opinion. Bluestar had a prophecy about her, and she was destined to become leader of ThunderClan. But she had kits, and queens could not be made deputy, and even worse, Thistleclaw would have been made deputy. She did not want to give up her kits, but Goosefeather had told her, "These kits are not part of the prophecy" so she had no choice but to give them to Oakheart.