Should pawn shops be illegal

No. But they should be regulated to prevent being used as a fence for stolen goods.

The service they provide is for loans to those who could otherwise not get access to capital.