What is the best lock for school lockers?

If you want the very best lock that will fit on a school locker I would recommend the Master Lock 185D. It is a keyed lock, not a combination lock. It is a very high security lock that is vandalism-resistant and is not easily cut or shimmed.