Was slavery legal in all colonies for many years?

Yes it was... The north finally decided that slavery should be abolished finally since they did not use slaves. When Abraham Lincoln got elected that started the war.