Why When you turn your key on all the lights come on but the car wont turn over?

Could be that the battery is still too week to turn the starter. beyond that, it is probably a starter issue. If the wiring is not loose at the starter. More than likely it is a bad solenoid or starter. One little trick is to give the starter a couple of light taps (don't try to kill it) with a hammer or semi heavy blunt instrument. Sometimes as they get older they will seize and blunt force knocks it loose.