Do you have to pay for a moshi monster?

no there is a free account

the paid account gives you access to members only shops.

and gives more features.

but the free account is fun in itself!