Are world war 2 photos worth anything?

Yes. Just check out eBay in the category Collectibles | Miliaria | WW2 (1939-1945). The value will depend on many things. For example if you have a photo that is dated and identified (this includes news release photos) they can sale for $10 to $15 or higher. Letters are more valuable if they are FROM a soldier and the unit is known. Some units are more collectible than others. The MAIN thing is that items in a GROUP may be worth more than the items sold seperately. If you have a Photo of a soldier in uniform, some letters from him and a medal with his name on it, then that group will be worth double or triple the sum you would get if you sold them individually.